Skip to content

Commit

Permalink
Changed table headers on View Issues page to use <th>. Added some CSS…
Browse files Browse the repository at this point in the history 
… class names.

Issue #11908

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
  • Loading branch information
@kornelski @davidhicks
kornelski authored and davidhicks committed May 11, 2010
1 parent d3f2749 commit d1af267
Showing 1 changed file with 54 additions and 54 deletions.
108 changes: 54 additions & 54 deletions core/columns_api.php
View file
Expand Up @@ -408,7 +408,7 @@ function columns_remove_invalid( $p_columns, $p_columns_all ) {
* @access public
*/
function print_column_title_selection( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td> &nbsp; </td>';
echo '<th class="column-selection"> &nbsp; </th>';
}

/**
Expand All @@ -420,7 +420,7 @@ function print_column_title_selection( $p_sort, $p_dir, $p_columns_target = COLU
* @access public
*/
function print_column_title_edit( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td> &nbsp; </td>';
echo '<th class="column-edit"> &nbsp; </th>';
}

/**
Expand All @@ -432,10 +432,10 @@ function print_column_title_edit( $p_sort, $p_dir, $p_columns_target = COLUMNS_T
* @access public
*/
function print_column_title_id( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-id">';
print_view_bug_sort_link( lang_get( 'id' ), 'id', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'id' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -447,10 +447,10 @@ function print_column_title_id( $p_sort, $p_dir, $p_columns_target = COLUMNS_TAR
* @access public
*/
function print_column_title_project_id( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-project">';
print_view_bug_sort_link( lang_get( 'email_project' ), 'project_id', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'project_id' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -462,10 +462,10 @@ function print_column_title_project_id( $p_sort, $p_dir, $p_columns_target = COL
* @access public
*/
function print_column_title_reporter_id( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-reporter">';
print_view_bug_sort_link( lang_get( 'reporter' ), 'reporter_id', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'reporter_id' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -477,10 +477,10 @@ function print_column_title_reporter_id( $p_sort, $p_dir, $p_columns_target = CO
* @access public
*/
function print_column_title_handler_id( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-assigned-to">';
print_view_bug_sort_link( lang_get( 'assigned_to' ), 'handler_id', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'handler_id' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -492,10 +492,10 @@ function print_column_title_handler_id( $p_sort, $p_dir, $p_columns_target = COL
* @access public
*/
function print_column_title_priority( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-priority">';
print_view_bug_sort_link( lang_get( 'priority_abbreviation' ), 'priority', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'priority' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -507,10 +507,10 @@ function print_column_title_priority( $p_sort, $p_dir, $p_columns_target = COLUM
* @access public
*/
function print_column_title_reproducibility( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-reproducibility">';
print_view_bug_sort_link( lang_get( 'reproducibility' ), 'reproducibility', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'reproducibility' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -522,10 +522,10 @@ function print_column_title_reproducibility( $p_sort, $p_dir, $p_columns_target
* @access public
*/
function print_column_title_projection( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-projection">';
print_view_bug_sort_link( lang_get( 'projection' ), 'projection', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'projection' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -537,10 +537,10 @@ function print_column_title_projection( $p_sort, $p_dir, $p_columns_target = COL
* @access public
*/
function print_column_title_eta( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-eta">';
print_view_bug_sort_link( lang_get( 'eta' ), 'eta', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'eta' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -552,10 +552,10 @@ function print_column_title_eta( $p_sort, $p_dir, $p_columns_target = COLUMNS_TA
* @access public
*/
function print_column_title_resolution( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th>';
print_view_bug_sort_link( lang_get( 'resolution' ), 'resolution', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'resolution' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -567,10 +567,10 @@ function print_column_title_resolution( $p_sort, $p_dir, $p_columns_target = COL
* @access public
*/
function print_column_title_fixed_in_version( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th>';
print_view_bug_sort_link( lang_get( 'fixed_in_version' ), 'fixed_in_version', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'fixed_in_version' );
echo '</td>';
echo '</th>';
}

/**
Expand Down Expand Up @@ -598,12 +598,12 @@ function print_column_title_target_version( $p_sort, $p_dir, $p_columns_target =
*/
function print_column_title_view_state( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
global $t_icon_path;
echo '<td>';
echo '<th class="column-view-state">';
$t_view_state_text = lang_get( 'view_status' );
$t_view_state_icon = '<img src="' . $t_icon_path . 'protected.gif" alt="' . $t_view_state_text . '" title="' . $t_view_state_text . '" />';
print_view_bug_sort_link( $t_view_state_icon, 'view_state', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'view_state' );
echo '</td>';
echo '</th>';
}

/**
Expand Down Expand Up @@ -646,10 +646,10 @@ function print_column_title_os_build( $p_sort, $p_dir, $p_columns_target = COLUM
*/
function print_column_title_build( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
if( $p_columns_target != COLUMNS_TARGET_CSV_PAGE ) {
echo '<td>';
echo '<th class="column-build">';
print_view_bug_sort_link( lang_get( 'build' ), 'build', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'build' );
echo '</td>';
echo '</th>';
} else {
echo lang_get( 'build' );
}
Expand All @@ -664,10 +664,10 @@ function print_column_title_build( $p_sort, $p_dir, $p_columns_target = COLUMNS_
* @access public
*/
function print_column_title_platform( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-platform">';
print_view_bug_sort_link( lang_get( 'platform' ), 'platform', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'platform' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -679,10 +679,10 @@ function print_column_title_platform( $p_sort, $p_dir, $p_columns_target = COLUM
* @access public
*/
function print_column_title_version( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-version">';
print_view_bug_sort_link( lang_get( 'product_version' ), 'version', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'version' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -694,10 +694,10 @@ function print_column_title_version( $p_sort, $p_dir, $p_columns_target = COLUMN
* @access public
*/
function print_column_title_date_submitted( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-date-submitted">';
print_view_bug_sort_link( lang_get( 'date_submitted' ), 'date_submitted', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'date_submitted' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -712,7 +712,7 @@ function print_column_title_attachment_count( $p_sort, $p_dir, $p_columns_target
global $t_icon_path;
$t_attachment_count_text = lang_get( 'attachment_count' );
$t_attachment_count_icon = "<img src=\"${t_icon_path}attachment.png\" alt=\"$t_attachment_count_text\" title=\"$t_attachment_count_text\" />";
echo "\t<td>$t_attachment_count_icon</td>\n";
echo "\t<th class=\"column-attachments\">$t_attachment_count_icon</th>\n";
}

/**
Expand All @@ -724,10 +724,10 @@ function print_column_title_attachment_count( $p_sort, $p_dir, $p_columns_target
* @access public
*/
function print_column_title_category( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-category">';
print_view_bug_sort_link( lang_get( 'category' ), 'category', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'category' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -739,10 +739,10 @@ function print_column_title_category( $p_sort, $p_dir, $p_columns_target = COLUM
* @access public
*/
function print_column_title_sponsorship_total( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo "\t<td>";
echo "\t<th class=\"column-sponsorship\">";
print_view_bug_sort_link( sponsorship_get_currency(), 'sponsorship_total', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'sponsorship_total' );
echo "</td>\n";
echo "</th>\n";
}

/**
Expand All @@ -754,10 +754,10 @@ function print_column_title_sponsorship_total( $p_sort, $p_dir, $p_columns_targe
* @access public
*/
function print_column_title_severity( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-severity">';
print_view_bug_sort_link( lang_get( 'severity' ), 'severity', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'severity' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -769,10 +769,10 @@ function print_column_title_severity( $p_sort, $p_dir, $p_columns_target = COLUM
* @access public
*/
function print_column_title_status( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-status">';
print_view_bug_sort_link( lang_get( 'status' ), 'status', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'status' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -784,10 +784,10 @@ function print_column_title_status( $p_sort, $p_dir, $p_columns_target = COLUMNS
* @access public
*/
function print_column_title_last_updated( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-last-modified">';
print_view_bug_sort_link( lang_get( 'updated' ), 'last_updated', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'last_updated' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -814,7 +814,7 @@ function print_column_title_summary( $p_sort, $p_dir, $p_columns_target = COLUMN
* @access public
*/
function print_column_title_bugnotes_count( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td> # </td>';
echo '<th class="column-bugnotes-count"> # </th>';
}

/**
Expand All @@ -826,9 +826,9 @@ function print_column_title_bugnotes_count( $p_sort, $p_dir, $p_columns_target =
* @access public
*/
function print_column_title_description( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-description">';
echo lang_get( 'description' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -840,9 +840,9 @@ function print_column_title_description( $p_sort, $p_dir, $p_columns_target = CO
* @access public
*/
function print_column_title_steps_to_reproduce( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-steps-to-reproduce">';
echo lang_get( 'steps_to_reproduce' );
echo '</td>';
echo '</th>';
}

/**
Expand All @@ -854,19 +854,19 @@ function print_column_title_steps_to_reproduce( $p_sort, $p_dir, $p_columns_targ
* @access public
*/
function print_column_title_additional_information( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-additional-information">';
echo lang_get( 'additional_information' );
echo '</td>';
echo '</th>';
}

function print_column_title_overdue( $p_sort, $p_dir, $p_columns_target = COLUMNS_TARGET_VIEW_PAGE ) {
global $t_icon_path;
echo '<td>';
echo '<th class="column-overdue">';
$t_overdue_text = lang_get( 'overdue' );
$t_overdue_icon = '<img src="' . $t_icon_path . 'overdue.png" alt="' . $t_overdue_text . '" title="' . $t_overdue_text . '" />';
print_view_bug_sort_link( $t_overdue_icon, 'due_date', $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, 'due_date' );
echo '</td>';
echo '</th>';
}

/**
Expand Down Expand Up @@ -911,14 +911,14 @@ function print_column_selection( $p_bug, $p_columns_target = COLUMNS_TARGET_VIEW
* @access public
*/
function print_column_title_plugin( $p_column, $p_column_object, $p_sort, $p_dir, $p_columns_target=COLUMNS_TARGET_VIEW_PAGE ) {
echo '<td>';
echo '<th class="column-plugin">';
if ( $p_column_object->sortable ) {
print_view_bug_sort_link( string_display_line( $p_column_object->title ), $p_column, $p_sort, $p_dir, $p_columns_target );
print_sort_icon( $p_dir, $p_sort, $p_column );
} else {
echo string_display_line( $p_column_object->title );
}
echo '</td>';
echo '</th>';
}

/**
Expand Down

0 comments on commit d1af267

Please sign in to comment.