From e41119dc9e4ed5f87991a095b523379032d24004 Mon Sep 17 00:00:00 2001 From: John Reese Date: Mon, 12 Jan 2009 13:16:02 -0500 Subject: [PATCH] Follow-up to a2294e9d and 8ed85ce6: Fix tag SQL to work on all database types while removing duplication. --- core/tag_api.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/tag_api.php b/core/tag_api.php index 51b5f9904f..3362c28459 100644 --- a/core/tag_api.php +++ b/core/tag_api.php @@ -413,9 +413,8 @@ function tag_get_candidates_for_bug( $p_bug_id ) { $t_params = array(); if ( 0 != $p_bug_id ) { $t_bug_tag_table = db_get_table( 'mantis_bug_tag_table' ); - $query = 'SELECT DISTINCT t.id, t.name, t.description FROM ' . - $t_bug_tag_table . - ' t2 LEFT JOIN ' . $t_tag_table . ' t ON t.id = t2.tag_id WHERE NOT bug_id = ' . db_param(); + $query = "SELECT t.id, t.name, t.description FROM $t_tag_table t + WHERE t.id IN ( SELECT tag_id FROM $t_bug_tag_table WHERE bug_id != " . db_param() . ' )'; $t_params[] = $p_bug_id; } else { $query = 'SELECT id, name, description FROM ' . $t_tag_table;