Skip to content

Commit

Permalink
Implementing PR revision comments
Browse files Browse the repository at this point in the history
- make it obvious that the html_operation_confirmation() in bug report
  and news update pages are successful
- use a temp variable to define the buttons instead of directly passing
  an array as function parameter
  • Loading branch information
dregad committed Sep 21, 2016
1 parent 68bd874 commit eabc07c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions bug_report.php
Expand Up @@ -323,10 +323,11 @@
}
}

html_operation_confirmation( array(
$t_buttons = array(
array( string_get_bug_view_url( $t_bug_id ), sprintf( lang_get( 'view_submitted_bug_link' ), $t_bug_id ) ),
array( 'view_all_bug_page.php', lang_get( 'view_bugs_link' ) ),
) );
);
html_operation_confirmation( $t_buttons, CONFIRMATION_TYPE_SUCCESS );

if( $f_report_stay ) {
?>
Expand Down
5 changes: 3 additions & 2 deletions news_update.php
Expand Up @@ -69,10 +69,11 @@

echo '<div class="space-20"></div>';

html_operation_confirmation( array(
$t_buttons = array(
array( 'news_menu_page.php' ),
array( 'news_edit_page.php?news_id=' . $f_news_id . '&action=edit', lang_get( 'edit_link' ) ),
) );
);
html_operation_confirmation( $t_buttons, CONFIRMATION_TYPE_SUCCESS );

echo '<br />';

Expand Down

0 comments on commit eabc07c

Please sign in to comment.