From eabc07ca928eb697aefa2f4b5ad7367c11f0e5cd Mon Sep 17 00:00:00 2001 From: Damien Regad Date: Sat, 17 Sep 2016 15:29:12 +0200 Subject: [PATCH] Implementing PR revision comments - make it obvious that the html_operation_confirmation() in bug report and news update pages are successful - use a temp variable to define the buttons instead of directly passing an array as function parameter --- bug_report.php | 5 +++-- news_update.php | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/bug_report.php b/bug_report.php index 259b94a5f3..883f1f38fe 100644 --- a/bug_report.php +++ b/bug_report.php @@ -323,10 +323,11 @@ } } -html_operation_confirmation( array( +$t_buttons = array( array( string_get_bug_view_url( $t_bug_id ), sprintf( lang_get( 'view_submitted_bug_link' ), $t_bug_id ) ), array( 'view_all_bug_page.php', lang_get( 'view_bugs_link' ) ), -) ); +); +html_operation_confirmation( $t_buttons, CONFIRMATION_TYPE_SUCCESS ); if( $f_report_stay ) { ?> diff --git a/news_update.php b/news_update.php index 2ef559724a..dcca20cb5c 100644 --- a/news_update.php +++ b/news_update.php @@ -69,10 +69,11 @@ echo '
'; -html_operation_confirmation( array( +$t_buttons = array( array( 'news_menu_page.php' ), array( 'news_edit_page.php?news_id=' . $f_news_id . '&action=edit', lang_get( 'edit_link' ) ), -) ); +); +html_operation_confirmation( $t_buttons, CONFIRMATION_TYPE_SUCCESS ); echo '
';