marick

some gems

Some dork inverted the sense of both the tests and the code.

Arguably more sensible use of logger.

Moved the log method up into CritterObject.

Log all requests.

Moved calculation of animal-procedure mismatches into the app itself.

There will soon be 2 types of exclusions, so renamed 'exclusions' method and json tag to make more specific.

Pushed stringification of objects out of Timeslice and into Externalizer.

Forgot to add these new tests.

HashMaker no longer needed.

Exclusions are now always maintained as a procedure => animal list hash.

Now that Timeslice has state, the controller should get a new one with each request.

Moved behavior into Timeslice.

Pushing handling of exclusions and procedures into the timeslice.

Missing return of self.

No need for a to_i

As the name suggests, "tweak_reservation" did too many things.

Convert jsonify() to externalize(). And no need for it to take a block.

Moved conversion of json to internal format into own class.

Much sped up creation of time-invariant exclusions.

Bugfix: If an animal was used more than once in a reservation, the reservation would appear twice in its list of reservations.

Speed up loading of the reservation table.

Query optimization where needed.

Turn sequel logging on in development version.

Added first version of Logger + a page to display log.

firefox handles connections differently. first workaround

debugging help to figure out what is up with heroku staging server

The pending reservation table now updates.

Followed unavailable-for-taking-out-of-service path through the server.

Scaffolding for displaying HTML table containing un-take-out-of-service-able animals.

Debugging support for asynchronous requests.

Clearer message on Restart button.

Added Restart button.

Finished rearranging existing Cib setup.

Starting move to using lazy getters to straighten out this logic.

Have page controller handle the two panels.

Taking animals out of service works all the way down to the database.

Taking animals out of service trail now coded down to the server.

Make default date for taking an animal out of service today.

Bugfix: expectation failures on listener mocks didn't cause the whole test to fail.

Added button that sends choice of animals to take out of service down to server.

The page for taking animals out of service now displays the in-service animals in a pair of name lists.

Moved some layout code from NameListControllerSubgraph to NameListPanel.

Removed vestiges of days when there was a single group.

stray global variable converted to local

Changes to handle animal-in-service data blob coming back from server.

Hoisted common code out of FromToNamedObjectListControllerPMR

When asked for animals that can be put out of service, only return ones without pending reservations.

Revised removal-from-service interface

Implemented get '/json/animal_deletion_info'

Animal deletion workflow down through PersistentStore.

Subclasses for Future seem unnecessary.

Switched page for making reservations over to the new style of state machine.

Hoist StepPDA into the util directory as Step.

Began generalizing coordinators into StateMachineCoordinators.

Made and used a PageControllerSubgraph class

Made and used a PageControllerSubgraph class.

Have NameListControllerSubgraph allow subclass to override Y position.

Put dummy implementation of connectOutlets.

First pass at making and hooking up all the bits that go into a new page.

Tiny cleanup

Split the NamedObjectListController into two classes.

NamedObjectListController is a better name than NamedObjectController

Now that notification-sending isn't a behavior of PanelController, the CurrentGroupPanel needs to be added explicitly.

Push notification-sending behavior down into AdvisorPanelController, which is the only class that uses it.

Need to be more unambiguous with names now that I'm adding another complicated page.

Generalised NameListControllerSubgraph and NamedObjectController

Generalize Subgraph.j

Made PageController superclass

cleaned up names for Future testing

page for viewing animals is now used only for taking them out of service

split Windows menu into Animals and Reservations menus

Extract delete form into own method.

Include effective date in deletion form.

delete_button takes optional argument: the text on the button

Merge branch 'animals'

when sorting animal names, ignore case

moved main controller file into subdir

make a controller subdirectory

First version of animal table - does nothing but possess a delete button.

Controller now passes /animals request onto an AnimalListView

Moved JSONURI into here.

Client-side code for animal table.

Added AnimalTableFuture and extracted TableFuture.

First of several methods that use asynchronous connections.

Removed a stray duplicate method.

Renaming and documenting a class-to-override.

The PersistentStore has begun to send asynchronous requests off to "Future" objects.

Starting to add objects that asynchronously make ajax calls

moved html-table-retrieval to use notifications

added busy-spinners

added busy-spinners

now a menu item for viewing animals. Empty for now.

tweaking various classes to be ready for adding another viewing-a-table-of-HTML page

tweaking various classes to be ready for adding another viewing-a-table-of-HTML page

put viewing-reservations-page-specific files in their own dirs

added guicho

Use TimeControl in DateTimeEditingControl

changed day_segment to time on server side

changed day_segment to time on server side

migration to make time-of-day more than binary valued

added evenings on the client side

added evening on server side

added migration for Guicho

added (not-yet-working) button to make copy of just-finished reservation

gradually moving more and more behavior out of Coordinator into the state machine

moving toward having the persistent store return results through notifications rather than return values.

don't use a collecting parameter

Use new StepPMR method that reminds when state needs to be changed before event fired

added method that suggests correct order for resigning and generating events

import Constants.j

more notification names

First version of storing reservation

first cut at state that gathers group data

Test resigning in favor of next step

let's hear it for subclasses\!

First step: gathering Time, Requester, etc.

Base class for state machine states

both ways to retrieve exclusions can now optionally ignore those due to a given reservation

ProcedureRules is now sleeping with the fishes

supply procedure description kind

cosmetic

update for new handling of procedure_description_kind

Wiring moving toward making copying work

Merge branch 'exclude-procedures'

begin work of getting procedures to exclude each other

pushed ability to exclude objects up to NamedObjectController

have to fake out column names with underscores?

don't need procedure rules any more - done on client side

now caches time-invariant exclusions on the client side

now caches time-invariant exclusions on the client side

a harmless animal lister

procedure-kind is now an attribute

procedure_description_kind is now a direct attribute of Animal, instead of being calculated

add task to cache time-invariant exclusions in Capp code

removed logging

use globals for logging

bit more logging

added task to update staging server with data from production

rules are too simple to have their own subdirectory; added BovineOnly rule

tidy: fix duplicate class names in migrations

old Reservation.random was lame. Better version takes animal and procedure as hash arguments

no more need for expanded_uses view

moved behavior from Use to Timeslice

moved behavior from Use to Timeslice

hash maker now has to handle actual objects instead of primitives

corrected use of mocks

change to call since procedure rules now know their own procedure

procedures can now return rules that apply to them

add collecting argument

use mocks

extracted superclass

forgot "once" on should_receive

in test config, do not add contents to tables

clean up admin scripts

Added ProcedureRules

move to model where timeslice, rules add to an array argument

start using OpenStructs instead of domain objects

starting to add rules

empty version

last use of ExclusionMap converted to use TimeSlice instead