@@ -146,7 +146,7 @@ module Mack def text_area(name, *args) var = instance_variable_get("@#{name}") fe = FormElement.new(*args) - options = {:name => name, :id => name} + options = {:name => name, :id => name, :cols => 60, :rows => 20} if var.nil? value = fe.options[:value] fe.options.delete(:value) lib/mack/view_helpers/form_helpers.rb @@ -199,21 +199,21 @@ describe Mack::ViewHelpers::FormHelpers do describe "text_area" do it "should create a nested text_area for a model" do - text_area(:cop, :full_name).should == %{<textarea id="cop_full_name" name="cop[full_name]">ness</textarea>} + text_area(:cop, :full_name).should == %{<textarea cols="60" id="cop_full_name" name="cop[full_name]" rows="20">ness</textarea>} end it "should create a non-nested text_area for a simple object" do - text_area(:simple).should == %{<textarea id="simple" name="simple">hi</textarea>} + text_area(:simple).should == %{<textarea cols="60" id="simple" name="simple" rows="20">hi</textarea>} end it "should create a non-nested text_area for just a symbol" do - text_area(:unknown).should == %{<textarea id="unknown" name="unknown"></textarea>} - text_area(:unknown, :value => "hi there").should == %{<textarea id="unknown" name="unknown">hi there</textarea>} + text_area(:unknown).should == %{<textarea cols="60" id="unknown" name="unknown" rows="20"></textarea>} + text_area(:unknown, :value => "hi there").should == %{<textarea cols="60" id="unknown" name="unknown" rows="20">hi there</textarea>} end it "should create a nested text_area for a model with an empty value if value is false" do @cop.full_name = nil - text_area(:cop, :full_name).should == %{<textarea id="cop_full_name" name="cop[full_name]"></textarea>} + text_area(:cop, :full_name).should == %{<textarea cols="60" id="cop_full_name" name="cop[full_name]" rows="20"></textarea>} end end test/unit/view_helpers/form_helpers_spec.rb f0d18532946d7f9d0d4106245d3836eb1ff81c3f Mark Bates mark@markbates.com http://github.com/markbates/mack/commit/b9bda035ceb0ea653f83523e4660f4e45b5b2070 b9bda035ceb0ea653f83523e4660f4e45b5b2070 2008-08-15T08:33:51-07:00 2008-08-15T08:32:59-07:00 Added cols and rows defaults to the text_area form helper. [#19] 41981b3244bb451a6f2ef8d4e6efca1e5dd79977 Mark Bates mark@markbates.com