The header moved location in libcdio-paranoia-0.90 (and correction patch from upstream!) #46

ssuominengentoo · 2013-01-17T15:50:10Z

include <cdio/cdda.h> is now <:cdio/paranoia/cdda.h>

In the paranoia subdirectory. Same for paranoia.h. The move was intentional.

This patch has been adopted by Arch, Fedora, Gentoo, and so forth because the
default installation out of libcdio-paranoia-0.90 was already supposed to do it
but the tarball is missing this patch unfortunately:

rocky/libcdio-paranoia@b2807f3

So you have to change the path using AC_CHECK_HEADER and #ifdef.

Please read this bug and look at the patch and you know howto fix it:

https://bugzilla.gnome.org/show_bug.cgi?id=691841

Direct link to example patch:

https://bugzilla.gnome.org/attachment.cgi?id=233609

The text was updated successfully, but these errors were encountered:

matiasdelellis · 2013-01-17T17:59:30Z

Hi,
As always .. thank you very much!.

Tomorrow see it!-)

Any idea if this bug fixed?
#4

ssuominengentoo · 2013-01-18T03:53:14Z

Issue 4 seems to be fixed at least in combination of using Pragha 1.1.1 and libcdio-paranoia-0.90.

matiasdelellis · 2013-01-22T14:58:37Z

Pragha in fedora was recompile with libparanoia 0.90 without any change.

http://koji.fedoraproject.org/koji/buildinfo?buildID=376944

I really need the change?

ssuominengentoo · 2013-01-22T16:02:03Z

Yes, because fedora is just temporarily installing to both cdio/cdda.h and cdio/paranoia/cdda.h and same for paranoia.h to allow builds to complete without issues
I went the hard road and decided not to do such temporary duplication and fix the dependencies instead
And we are in agreement with the Fedora maintainer as you can see in the gnome bug earlier I referenced

So if you want pragha to compile anywhere else than Fedora...

matiasdelellis · 2013-01-22T16:36:35Z

Yes, because fedora is just temporarily installing to both cdio/cdda.h and cdio/paranoia/cdda.h and same for paranoia.h to allow builds to complete without issues

Ok. Had searched, but not found information.

So if you want pragha to compile anywhere else than Fedora...

Haha. Obviously. In a moment fix it. ;)

Regards.

matiasdelellis · 2013-01-30T23:32:18Z

Please ssuominengentoo, Test last commit in git.

Regards,
Matias.

Looking examples seems that <cdio/cd_types.h> no change. And <cdio/paranoia/cdio_unconfig.h> no exist.. No????? Also test if issue #4 was fixed with libcdio 0.90

dumblob · 2013-01-31T20:23:46Z

Hi, I've looked at it and unfortunately it could not work. The DEVS is exported to config.h which is in turn included from pragha.h but after cdda.h which uses the HAVE_PARANOIA_NEW_INCLUDES macro defined in config.h .
I'm not sure, why the comment "Should be before config.h, libcdio 0.83 issue" resides in pragha.h, but on my system (Arch linux 3.7.5-1-ARCH x86_64) works everything fine with #include <config.h> before #include "cdda.h".

dumblob · 2013-01-31T20:28:24Z

*#include <config.h> before #include "cdda.h".

matiasdelellis · 2013-01-31T20:52:02Z

HAVE_PARANOIA_NEW_INCLUDES macro defined in config.h .

Ohh.. You're right!. :S

Should be before config.h, libcdio 0.83 issue

See the issue #4
Basically because libcdio 0.83 export some vars/defines like PACKAGE and PACKAGE_VERSION, and provides many problems. (For example that pragha always show as version 0.83)
The way to fix is adding all cdio headers before config.h of pragha, and also add the header cdio/cdio_unconfig.h to remove the bad defines.Once removed Pragha can override these defines.

Will try later again.. I'm answering from my mother's computer. =)

Regards,
Matias.

matiasdelellis · 2013-01-31T20:56:01Z

p.s: Looks like it was fixed in 0.90, but need that it work for both versions!

matiasdelellis · 2013-02-01T14:21:23Z

I do not know.
I do not see how to work with libcdio 0.83 and 0.90.

When released libcdio 0.83 did shit!, and now back to them!. :@

Sorry .. I am annoyed..

dumblob · 2013-02-01T16:32:09Z

Be bleeding edge and abandon support for libcdio 0.83 :-)
No, I'm just kidding. I have no idea what to do with that :-(

ssuominengentoo · 2013-02-01T16:41:35Z

Come on, Issue #4 is really only cosmetics, it's fine to close it off as "Fixed in cdio 0.90"
However this Issue is the one that needs fixing and is not plain cosmetics
Just make the README or somesuch say "libcdio 0.90 is recommended, 0.83 required"

ghost · 2013-02-01T16:53:01Z

@matiasdelellis no libcdio no cry :3

matiasdelellis · 2013-02-01T17:37:51Z

Come on, Issue #4 is really only cosmetics, it's fine to close it off as "Fixed in cdio 0.90"

Yes!!. But still bothers me the stupidity that they did with 0.83. With 0.81 also worked properly.

Just make the README or somesuch say "libcdio 0.90 is recommended, 0.83 required"

Well.. Sorry @ssuominengentoo

I will do that, but in reverse..
Fedora 18 (The distibution that use), The future ubuntu 13.4 [1], and surely Debian still use 0.83. So, By now I will leave ready for 0.83, together with the required patches for 0.90 commented. Whoever that use 0.90, should uncomment this. Of course properly commented in README.

@rat4
Issue #47 ?? From this... practically planned for 1.1.3. ¿Also port cdda to musicbrainz? hahaha. =)

[1] http://packages.ubuntu.com/km/raring/libcdio-paranoia-dev

ssuominengentoo · 2013-02-01T17:41:27Z

commented.. what? where as proper AC_CHECK_HEADER could be added and close the issue for good in very simple way
didn't realize this app was Fedora only, and even that without rawhide support :/

matiasdelellis · 2013-02-01T18:02:39Z

Any point of view was developed only for fedora!. Never!.

But.. Something that is not clarify..
Not is only a cosmetic error!. The database pragha 0.83 is incompatible with the 0.90 or newest. It also implies a problem with that!.

If I'm not mistaken, commenting pragha.h line 23, it works fine!. no? (TRY IT PLEASE) It's the only thing that should be clarified in the README!.

matiasdelellis · 2013-02-01T18:15:29Z

Attempt to generate the less possible problems. also try to keep the minimum dependencies!. I think it's more correct to help people trying to use a stable distibution. No regrets for distributions like Arch or Gentoo, I love them!. But if you're willing to install the latest packages, you have to be willing to fix these inconveniences. I usually do too!.
0.90 adds something truly revolutionary? I can not find it. So.. I will force someone to install it? (Implying recompile all packages that depend on it).

I not want create any conflict. Sorry if I offended or something.
Regards.

matiasdelellis · 2013-02-08T13:19:35Z

Please..
Celeting line 23 is working?
Will release Pragha 1.1.2 the weekend. I promise that the next release will depend on 0.90.

dumblob · 2013-02-08T21:45:49Z

Yes, commenting the line 23 in pragha.h works for me (Arch Linux 3.7.5 x86_64; libcdio 0.90).

matiasdelellis · 2013-02-08T22:22:48Z

Ok.
Thank you very much!. ;)

LazyKent · 2013-02-19T09:38:12Z

And now I have a problem in openSUSE.

[    7s] checking cdio/paranoia/cdda.h usability... no
[    7s] checking cdio/paranoia/cdda.h presence... no
[    7s] checking for cdio/paranoia/cdda.h... no

cdda.h is installed in cdio/

matiasdelellis · 2013-02-19T14:34:08Z

libcdio-paranoia-0.90? or 0.83?
Where I can see the opensuse packages? to see who made..

LazyKent · 2013-02-19T15:01:30Z

libcdio-paranoia git snapshot 4c905cc1aa (Mar 18, 2012).

https://build.opensuse.org/package/show?project=multimedia%3Alibs&package=libcdio-paranoia

ssuominengentoo · 2013-02-19T17:56:01Z

opensuse needs to update their libcdio-paranoia, that snapshot is very old, older than 0.90, older than 0.83, ...

LazyKent · 2013-02-19T18:27:46Z

No. It is 0.84. From the build log:

[    7s] checking pkg-config is at least version 0.9.0... yes
[    7s] checking for libcdio_paranoia >= 0.80... 10.2+0.84
[    7s] checking LIBCDIO_PARANOIA_CFLAGS...  
[    7s] checking LIBCDIO_PARANOIA_LIBS... -lcdio_paranoia -lcdio_cdda -lcdio

matiasdelellis · 2013-02-21T13:29:29Z

Nothing?
I'm downloading opensuse to try .. (Excuse to return to give him a chance.. jaja.)

matiasdelellis · 2013-02-21T19:14:19Z

Hi,
I'm here on a live usb of openSUSE 12.2 Kde.

Effectively is an older version of libdio, with some patches..
The messages that you show, only inform that no has 0.90. But compiles perfectly I am listening music in Pragha now.
It shows some other error?

EDIT: zypper update libcdio*, clarify that all packages are updated.

p.s: Nobody cares, but like always .. I love and hate opensuse!.

LazyKent · 2013-02-21T19:38:35Z

Yes. It compiles well and no other errors.

matiasdelellis · 2013-02-21T19:42:59Z

Ok. =)

ssuominengentoo · 2013-02-25T09:52:24Z

I just added version 1.1.2 to Gentoo's Portage and noticed it doesn't work out-of-box with the new header location because src/cdda.h never includes config.h so HAVE_PARANOIA_NEW_INCLUDES is never set

matiasdelellis · 2013-02-25T12:08:49Z

Fail in line 22?? Coment 22, 23, 24.

ssuominengentoo · 2013-02-25T13:53:49Z

You can just ./configure CPPFLAGS="-DHAVE_PARANOIA_NEW_INCLUDES" to make it compile, no need to comment out anything, like said, it's just missing the config.h include to get the define from in src/cdda.h

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

Looking examples seems that <cdio/cd_types.h> no change. And <cdio/paranoia/cdio_unconfig.h> no exist.. No????? Also test if issue #4 was fixed with libcdio 0.90

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

Looking examples seems that <cdio/cd_types.h> no change. And <cdio/paranoia/cdio_unconfig.h> no exist.. No????? Also test if issue #4 was fixed with libcdio 0.90

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

matiasdelellis added a commit that referenced this issue Jan 31, 2013

Issue #46

90bf7af

Looking examples seems that <cdio/cd_types.h> no change. And <cdio/paranoia/cdio_unconfig.h> no exist.. No????? Also test if issue #4 was fixed with libcdio 0.90

matiasdelellis mentioned this issue Jul 7, 2013

Compile error on lastest git clone #56

Closed

matiasdelellis pushed a commit that referenced this issue Jan 21, 2014

Depend on Gtk3 >= 3.4 and Glib >= 2.32 and ignore deprecations since …

106a806

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

ghost closed this as completed Feb 14, 2014

matiasdelellis added a commit that referenced this issue Jun 20, 2014

Depend on Gtk3 >= 3.4 and Glib >= 2.32 and ignore deprecations since …

78a1e19

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

matiasdelellis added a commit that referenced this issue Jun 20, 2014

Issue #46

766cbc6

Looking examples seems that <cdio/cd_types.h> no change. And <cdio/paranoia/cdio_unconfig.h> no exist.. No????? Also test if issue #4 was fixed with libcdio 0.90

matiasdelellis added a commit that referenced this issue Jun 20, 2014

Depend on Gtk3 >= 3.4 and Glib >= 2.32 and ignore deprecations since …

8908ad4

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

matiasdelellis added a commit that referenced this issue Jun 20, 2014

Issue #46

af319f9

Looking examples seems that <cdio/cd_types.h> no change. And <cdio/paranoia/cdio_unconfig.h> no exist.. No????? Also test if issue #4 was fixed with libcdio 0.90

matiasdelellis added a commit that referenced this issue Jun 20, 2014

Depend on Gtk3 >= 3.4 and Glib >= 2.32 and ignore deprecations since …

b420b05

…Gtk 3.10 First commit to port to GtkApplication. Depend on libcdio_paranoia >= 0.90, so fix issue #46

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The header moved location in libcdio-paranoia-0.90 (and correction patch from upstream!) #46

The header moved location in libcdio-paranoia-0.90 (and correction patch from upstream!) #46

ssuominengentoo commented Jan 17, 2013

matiasdelellis commented Jan 17, 2013

ssuominengentoo commented Jan 18, 2013

matiasdelellis commented Jan 22, 2013

ssuominengentoo commented Jan 22, 2013

matiasdelellis commented Jan 22, 2013

matiasdelellis commented Jan 30, 2013

dumblob commented Jan 31, 2013

dumblob commented Jan 31, 2013

matiasdelellis commented Jan 31, 2013

matiasdelellis commented Jan 31, 2013

matiasdelellis commented Feb 1, 2013

dumblob commented Feb 1, 2013

ssuominengentoo commented Feb 1, 2013

ghost commented Feb 1, 2013

matiasdelellis commented Feb 1, 2013

ssuominengentoo commented Feb 1, 2013

matiasdelellis commented Feb 1, 2013

matiasdelellis commented Feb 1, 2013

matiasdelellis commented Feb 8, 2013

dumblob commented Feb 8, 2013

matiasdelellis commented Feb 8, 2013

LazyKent commented Feb 19, 2013

matiasdelellis commented Feb 19, 2013

LazyKent commented Feb 19, 2013

ssuominengentoo commented Feb 19, 2013

LazyKent commented Feb 19, 2013

matiasdelellis commented Feb 21, 2013

matiasdelellis commented Feb 21, 2013

LazyKent commented Feb 21, 2013

matiasdelellis commented Feb 21, 2013

ssuominengentoo commented Feb 25, 2013

matiasdelellis commented Feb 25, 2013

ssuominengentoo commented Feb 25, 2013

The header moved location in libcdio-paranoia-0.90 (and correction patch from upstream!) #46

The header moved location in libcdio-paranoia-0.90 (and correction patch from upstream!) #46

Comments

ssuominengentoo commented Jan 17, 2013

include <cdio/cdda.h> is now <:cdio/paranoia/cdda.h>

matiasdelellis commented Jan 17, 2013

ssuominengentoo commented Jan 18, 2013

matiasdelellis commented Jan 22, 2013

ssuominengentoo commented Jan 22, 2013

matiasdelellis commented Jan 22, 2013

matiasdelellis commented Jan 30, 2013

dumblob commented Jan 31, 2013

dumblob commented Jan 31, 2013

matiasdelellis commented Jan 31, 2013

matiasdelellis commented Jan 31, 2013

matiasdelellis commented Feb 1, 2013

dumblob commented Feb 1, 2013

ssuominengentoo commented Feb 1, 2013

ghost commented Feb 1, 2013

matiasdelellis commented Feb 1, 2013

ssuominengentoo commented Feb 1, 2013

matiasdelellis commented Feb 1, 2013

matiasdelellis commented Feb 1, 2013

matiasdelellis commented Feb 8, 2013

dumblob commented Feb 8, 2013

matiasdelellis commented Feb 8, 2013

LazyKent commented Feb 19, 2013

matiasdelellis commented Feb 19, 2013

LazyKent commented Feb 19, 2013

ssuominengentoo commented Feb 19, 2013

LazyKent commented Feb 19, 2013

matiasdelellis commented Feb 21, 2013

matiasdelellis commented Feb 21, 2013

LazyKent commented Feb 21, 2013

matiasdelellis commented Feb 21, 2013

ssuominengentoo commented Feb 25, 2013

matiasdelellis commented Feb 25, 2013

ssuominengentoo commented Feb 25, 2013