fix for bug #996 and related issues #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
added a commit
that referenced
this pull request
Jul 15, 2012
fix for bug #996 and related issues
| clippath, clippath_transform = gc.get_clip_path() | ||
| if all_transforms: | ||
| transforms = [numpy.dot(master_transform, t) for t in all_transforms] | ||
| if offset_position=='data': |
There was a problem hiding this comment.
I know its been merged already, but its worth mentioning that the lines:
if offset_position=='data':
offset_position = True
else:
offset_position = False
are exactly equivalent to:
offset_position = (offset_position=='data')
(un-necessary parentheses added for readability)
|
Out of interest, is the OSX backend purely graphical or would it be possible to add some unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for bug #996 (macosx backend broken by #901: QuadMesh fails so colorbar fails) and a few related issues.