Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken links in the gallery #1024

Merged
merged 1 commit into from Aug 3, 2012
Merged

broken links in the gallery #1024

merged 1 commit into from Aug 3, 2012

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Aug 3, 2012

the following links in the gallery
http://matplotlib.sourceforge.net/examples/pylab_examples/demo_tight_layout_00.html
http://matplotlib.sourceforge.net/examples/pylab_examples/demo_tight_layout_01.html
http://matplotlib.sourceforge.net/examples/axes_grid/demo_axes_divider_01.html
(and maybe others) do not work

error:

  1. Server: matplotlib.sourceforge.net
  2. URL path: /examples/pylab_examples/demo_tight_layout_00.html
  3. Error notes: NONE
  4. Error type: 404
  5. Request method: GET
  6. Request query string: NONE
  7. Time: 2012-07-19 09:12:32 UTC (1342689152)

The corresponding links in the examples (e.g. http://matplotlib.sourceforge.net/examples/pylab_examples/demo_tight_layout.html) are fine

@WeatherGod
Copy link
Member

Confirmed in master as well. Not sure where these are coming from because the string "demo_tight_layout_00" doesn't exist in any of the version-controlled files.

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

The attached pull request resolves this issue. I am now going to upload a fixed version of the 1.1.x docs based on this change.

@WeatherGod
Copy link
Member

I think your fix would also solve a few other problems I have had as well (left over .pyc files get picked up sometimes), unless I am completely mis-understanding the regex.

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

I don't think it will address that, because it's only use with things before the extension. All it really addresses is that some of the examples produce multiple groups of figures, and those were not getting correctly linked back to the single .py that produced them.

Go ahead and file another bug if you're seeing something related to left over .pyc files.

mdboom added a commit that referenced this pull request Aug 3, 2012
broken links in the gallery
@mdboom mdboom merged commit ff883a6 into matplotlib:v1.1.x Aug 3, 2012
@mdboom mdboom deleted the fix-gallery branch March 3, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants