Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fix to issue 196 on github for log=True and histtype='step' #1029

Closed
wants to merge 2 commits into from

Conversation

keflavich
Copy link
Contributor

A solution was proposed in Issue #196. This pull request implements that proposed solution.

@@ -7861,7 +7861,8 @@ def hist(self, x, bins=10, range=None, normed=False, weights=None,

x[0::2], x[1::2] = bins, bins

minimum = min(bins)
ndata = np.array(n)
minimum = (ndata[ndata>0].min())*0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't we only want to do this for 'log'? Also, since bins is a list and the operation is just a simple filter, let's go with that route.

Add a comment for the rationale for the filtering and also for the 0.1 multiplication.

only want to set min this way if log is specified.  Also, added case for
normed vs not
@keflavich
Copy link
Contributor Author

@WeatherGod - I think you're right, you only want to do it this way for log. You also want different minima for normed vs not.

@WeatherGod
Copy link
Member

Why 0.1? What is special about that number versus any other number? Could it accidentially be related to the fact that the default number of bins is 10 (I think)? If so, then we can't rely on that.

@keflavich
Copy link
Contributor Author

No, 0.1 corresponds to one tick label unit for log plots assuming log base
10.
On Jul 20, 2012 6:26 PM, "Benjamin Root" <
reply@reply.github.com>
wrote:

Why 0.1? What is special about that number versus any other number?
Could it accidentially be related to the fact that the default number of
bins is 10 (I think)? If so, then we can't rely on that.


Reply to this email directly or view it on GitHub:
#1029 (comment)

@WeatherGod
Copy link
Member

ok, so probably the only thing left is to add a test for this. If you need help with that, just let me know.

@mdboom
Copy link
Member

mdboom commented Jul 30, 2012

It should probably use the log's actual base -- it's 10 by default, but it could be anything.

@dmcdougall
Copy link
Member

This should go in v1.2.x, it's a fix. I'm milestoning it as such.

@keflavich Are you able to add a test for this? If not I can fork your branch and move this forward.

@ghost ghost assigned dmcdougall Jan 18, 2013
@keflavich
Copy link
Contributor Author

Best if you go ahead; I'll not have a chance for at least a week

@dmcdougall
Copy link
Member

Resolved in #1684.

@dmcdougall dmcdougall closed this Jan 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants