Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BoundaryNorm interpolation with numpy 1.7rc. #1260

Merged
merged 1 commit into from Sep 17, 2012

Conversation

efiring
Copy link
Member

@efiring efiring commented Sep 15, 2012

Closes github issue #1258.

@WeatherGod
Copy link
Member

I can confirm that this fixes the issue. Admittedly, I guess I would rather see the casting rules be a bit smarter in numpy when performing in-place operations. Because of this, we lose the ability to do an in-place multiplication, which could be a performance hit when the Norm is applied to much larger datasets.

@pelson
Copy link
Member

pelson commented Sep 17, 2012

@WeatherGod : I agree with your concerns, but don't feel that it should hold us up in getting a RC2 ready. Are you willing to merge & open a seperate issue (if there is something that can be done by us, and not in numpy itself)?

@WeatherGod
Copy link
Member

Heh, just noticed that the relevant code was actually recently changed to do the inplace operations (perhaps in one of the PEP8 changes?). Before, it was a single line doing the multiplication and casting and assigning back to the iret array. I still prefer if the in-place multiplication would work, but I am going to raise that issue on the numpy list instead. I will go ahead and merge this in.

WeatherGod added a commit that referenced this pull request Sep 17, 2012
Fix BoundaryNorm interpolation with numpy 1.7rc.
@WeatherGod WeatherGod merged commit ab3e42f into matplotlib:v1.2.x Sep 17, 2012
@efiring
Copy link
Member Author

efiring commented Sep 17, 2012

Yes, it was in the PEP8 change, #1a07db586e.

@efiring efiring deleted the boundary_norm_interp branch May 29, 2013 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants