Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny bugfixes in image.py #1328

Closed
wants to merge 1 commit into from
Closed

Tiny bugfixes in image.py #1328

wants to merge 1 commit into from

Conversation

semenko
Copy link
Contributor

@semenko semenko commented Oct 4, 2012

zeros -> numpy.zeros (otherwise undefined)
FigureCanvasPDF -> FigureCanvasPdf (otherwise undefined)

Signed-off-by: Nick Semenkovich semenko@alum.mit.edu

zeros -> numpy.zeros (otherwise undefined)
FigureCanvasPDF -> FigureCanvasPdf (otherwise undefined)

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
@mdboom
Copy link
Member

mdboom commented Oct 4, 2012

Thanks. These are small, but rather serious. I think we should try to get this in the upcoming 1.2.0 release.

@dmcdougall
Copy link
Member

I agree. I also give this a +1. Though they are very serious bugs, they are very obvious fixes.

@pelson
Copy link
Member

pelson commented Oct 5, 2012

@mdboom : What is the preferred strategy here? Should we ask @semenko to rebase against 1.2.x, or should we just cherry pick the commit onto 1.2 directly?

@semenko
Copy link
Contributor Author

semenko commented Oct 5, 2012

Anything works for me -- sorry I didn't notice the v1.2.x branch!

@mdboom
Copy link
Member

mdboom commented Oct 5, 2012

There's no strict rule about this, but generally, if the branch can be rebased on v1.2.x and a new PR created against v1.2.x we end up with an easier-to-follow history.

@semenko
Copy link
Contributor Author

semenko commented Oct 5, 2012

Rebased in issue #1330

@semenko semenko closed this Oct 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants