PEP8 fixes on collections.py #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. Good work, Nelle. |
|
+1 |
| @@ -773,10 +778,10 @@ def __init__(self, xranges, yrange, **kwargs): | |||
| """ | |||
| ymin, ywidth = yrange | |||
| ymax = ymin + ywidth | |||
| verts = [ [(xmin, ymin), (xmin, ymax), (xmin+xwidth, ymax), (xmin+xwidth, ymin), (xmin, ymin)] for xmin, xwidth in xranges] | |||
| verts = [[(xmin, ymin), (xmin, ymax), (xmin + xwidth, ymax), ( | |||
There was a problem hiding this comment.
This seems to me like an odd, and not very readable, way to break up this chunk. I would break it after the comma, not
the parenthesis,
and probably put the "for xmin..." part on a separate line.
|
I've deleted imports and unused variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 fixes on the collections module !
Many thanks,
N