Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in IPython notebook #1443

Closed
pwuertz opened this issue Nov 1, 2012 · 8 comments
Closed

Regression in IPython notebook #1443

pwuertz opened this issue Nov 1, 2012 · 8 comments

Comments

@pwuertz
Copy link
Contributor

pwuertz commented Nov 1, 2012

I'm experiencing a regression when using matplotlib in ipython notebooks. When adding a legend to a graph, the displayed image in the notebook is clipped down to the legend. Try running this with ipython notebook --pylab=inline:

x = np.linspace(0, 1)
plt.plot(x, x**2, label="foo")
plt.legend()  # comment/uncomment
plt.show()

I bisected the regression down to commit 2f11dee from #1345 (PEP8 fixes on backend_bases.py).

@pwuertz
Copy link
Contributor Author

pwuertz commented Nov 1, 2012

I annotated the change that causes the issue in 2f11dee#commitcomment-2087091

@jenshnielsen
Copy link
Member

I believe this is identical to #1419 I have a fix and a test in #1420

@pelson
Copy link
Member

pelson commented Nov 1, 2012

Thanks for point this out @jenshnielsen, I agree, your PR addresses the line that @pwuertz commented on. @pwuertz does that fix it for you?

@pelson
Copy link
Member

pelson commented Nov 1, 2012

@jenshnielsen pointed out that this applies to the master branch, rather than the forthcoming v1.2.0 release. Can you confirm this @pwuertz?

Thanks,

@mdboom
Copy link
Member

mdboom commented Nov 1, 2012

If this is really the symptom of this bug with IPython, we should probably backport to 1.2.x.

@pwuertz
Copy link
Contributor Author

pwuertz commented Nov 1, 2012

The commit that triggered the problem has been applied to the master only. The 1.2.x branch works fine for me. The branch from @jenshnielsen fixes the issue. Thanks!

@pelson
Copy link
Member

pelson commented Nov 2, 2012

Just merged #1420 so I am closing this. @pwuertz : If I've incorrectly closed it, please feel free to re-open.

@pelson pelson closed this as completed Nov 2, 2012
@pwuertz
Copy link
Contributor Author

pwuertz commented Nov 2, 2012

Nope, just tested the new master. Everything is perfect now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants