FIX extra comma in Sankey.add #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
It looks like you also moved the My feeling is that the commit message should reflect the changes that are made. The commit message currently says you fixed an issue with a comma, but the init function was also moved. Sorry to be picky -- but it does make the logs and diffs easier to read. |
|
Also if anyone else disagrees, feel free to shoot me down. |
|
I've added this to the commit message |
dmcdougall
added a commit
that referenced
this pull request
Nov 13, 2012
FIX extra comma in Sankey.add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in one of my PEP8 patches: I added an extra comma. Hence, the code failed when calling it.
I fixed the error, and added a small test that just checks the code runs.