Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Boxplot median and confidence intervals computed with user-spec'd function #1486

Closed
wants to merge 8 commits into from

Conversation

phobson
Copy link
Member

@phobson phobson commented Nov 12, 2012

See:
#1199
and
https://gist.github.com/3747864

This PR contains modifications to the boxplot method in axes.py that allows the user to pass in a function that computes the medians and its confidence intervals.

I've rebased this branch on the current master -- I hope that ok. It went pretty smoothly so I'll be happy to base off of 1.2.x if needed.

Just ran all the tests and things ok.

I'm curious as to how we should proceed with all of the other features out lined in the links above. I'm thinking we should keep them separate? But I'll defer to the core team on that.

Thanks for looking at this.
-p

@dmcdougall
Copy link
Member

@phobson Yes! Awesome. I haven't looked at this yet but just wanted to say thanks for bearing the brunt. Hopefully this stuff will make it into the next release. Will report back (don't know when yet -- fairly busy) with feedback.

@dmcdougall
Copy link
Member

@phobson I haven't forgotten about you. Just been really snowed under recently.

@Tillsten
Copy link
Contributor

Tillsten commented Mar 4, 2013

@dmcdougall is there anything one can to revive this pr?

@phobson
Copy link
Member Author

phobson commented Mar 4, 2013

@Tillsten I've got a stack of these branches sitting in a my fork. First thing I can do is rebase them all and I'll work with @dmcdougall get them ready as our schedule allows.

@ghost ghost assigned dmcdougall Apr 1, 2013
@phobson
Copy link
Member Author

phobson commented Sep 20, 2013

@dmcdougall given my goals for the boxplot method that i mention here: #2447

I think we should go ahead and close this. Does that sound ok?

@tacaswell
Copy link
Member

@phobson @miggaiowski I think this overlaps with #2520 , you two should chat.

If you no longer want this to be active, please close it.

@phobson
Copy link
Member Author

phobson commented Nov 26, 2013

@tacaswell thanks, i'm closing this.

@phobson phobson closed this Nov 26, 2013
@phobson phobson deleted the function-boxplots branch January 27, 2014 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants