New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1504: changed how draw
handles alpha in markerfacecolor
#1505
Conversation
I am guess you will have to rebase your branch onto the latest master. I have yet to really look over the changes, but at first glance, it makes sense. |
I am in agreement with @WeatherGod here. This is a useful patch. Thanks for taking time out of your day to do this @tacaswell. When you rebase, you'll get some conflicts you'll need to fix. Then you'll need to |
rebased and forced as requested |
rebased and forced again |
@@ -961,6 +965,14 @@ def _get_rgb_face(self, alt=False): | |||
rgbFace = colorConverter.to_rgb(facecolor) | |||
return rgbFace | |||
|
|||
def _get_rgba_face(self, alt=False): | |||
facecolor = self._get_markerfacecolor(alt=alt) | |||
if is_string_like(facecolor) and facecolor.lower()=='none': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP8 nitpick: there should be spaces around ==
The code looks good. I've underlined a couple of PEP8 problems |
👍 LGTM, but I'm not a core dev, so my opinion doesn't matter :) I haven't run the tests, but I trust travis to do it (and not crash while doing it). |
👍 |
I trust you know that's not so @NelleV. @tacaswell - this looks good to me too. I think we can merge this happily. |
I don't really have a sufficient knowledge of matplotlib to do good reviews (but I do consider myself as being part of the PEP8 consistency brigade :) ) |
(PR matplotlib#1505). Tests added is matplotlib#1663 pass with this patch.
changed how
draw
handles alpha inmarkerfacecolor
so that the set value respected.At least in the Agg backend, the alpha value of the face color passed into draw_markers (in _backend_agg.cpp) is overridden by the value in gc_obj. It is not clear to me this in the correct behavior, but these changes fix the problem with minimal changes