Remove unnecessary clip cairo #1526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ctx.new_path() | ||
| RendererCairo.convert_path(ctx, clippath, clippath_trans) | ||
| ctx.clip() | ||
| ctx = gc.ctx |
There was a problem hiding this comment.
Is there any difference between gc.ctx and self.gc.ctx?
|
gc and self.gc are the same object. gc is obtained by calling new_gc, and new_gc always returns self.gc, which is created only once, in the initializer of RendererCairo. |
|
+1 |
|
Great. @mdehoon Would you be able to squash this down to a single commit? |
|
See mdehoon@8d15940 |
|
Fixed by #1538. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the draw_image function was simplified, the cairo backend was not updated.
Specifically, it's not necessary to perform clipping separately -- this has already been done when draw_image is being called.