Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scatterpoints to rcParam #1634

Merged
merged 4 commits into from Jan 15, 2013

Conversation

tacaswell
Copy link
Member

Addresses Issue #1633

Includes units test that errors out with out the rest of this pull.

@@ -46,3 +46,22 @@ def test_fancy():
plt.errorbar(range(10), range(10), xerr=0.5, yerr=0.5, label='XX')
plt.legend(loc="center left", bbox_to_anchor=[1.0, 0.5],
ncol=2, shadow=True, title="My legend", numpoints=1)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 nitpick: there should be only 2 lines instead of 3 here

@dmcdougall
Copy link
Member

I think this is fine to merge. I will leave this open for a day just in case any of the other developers have further feedback they wish to give.

@NelleV
Copy link
Member

NelleV commented Jan 15, 2013

👍 LGTM

@dmcdougall
Copy link
Member

Travis failures are duds. Merging.

dmcdougall added a commit that referenced this pull request Jan 15, 2013
@dmcdougall dmcdougall merged commit 02582f8 into matplotlib:master Jan 15, 2013
@tacaswell tacaswell deleted the scatterpoint_rcParam branch January 17, 2013 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants