added explicit 'zorder' kwarg to Colection and LineCollection.
#1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed class level zorder assignment. It is not strictly necessary for LineCollection to take zorder as a kwarg, but added to keep the default zorder the same
| @@ -959,6 +964,9 @@ def __init__(self, segments, # Can be None. | |||
| *pickradius* is the tolerance for mouse clicks picking a line. | |||
| The default is 5 pt. | |||
|
|
|||
| *zorder* | |||
| 2 the zorder of the LineCollection | |||
There was a problem hiding this comment.
This line should probably be more along the lines of:
|
Good stuff @tacaswell - I'm amazed we have come so far without zorder for Collections! |
|
Thanks @tacaswell, merging. |
|
(The Travis failures are duds) |
dmcdougall
added a commit
that referenced
this pull request
Jan 14, 2013
added explicit 'zorder' kwarg to `Colection` and `LineCollection`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vaguely related to issue #1622. Changed the location of the default zorder of Collection and LineCollection from a class level-member, to explicitly being a keyword argument.
I think this makes it clearer, but isn't strictly necessary, because if zorder is included as a kwarg, it will get set by the
self.updateanyway.