You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1674 is not entirely fixed. I got a flipped svg using imshow() with origin='lower'. The snippet at the bottom reproduces the issue with the current master branch. This problem was introduced between v1.1.1 and v1.2.0rc3.
I dug the issue a bit deeper, and found that 1c9f9b5 introduced the issue. The commit seems a performance tweak for nearest neighbor scaling in a certain condition. Reverting 1c9f9b5 and 8c25664 fixes the issue.
I suggest to revert both commits, but to keep the test cases introduced in 8c25664. @mdboom, is this ok for you to revert 1c9f9b5 for now?
Thank @tkanmae for bringing this up again. I should have git bisected from the outset rather than fiddling with the SVG backend. Sorry for the wild goose chase.
I think your proposed solution of reverting 1c9f9b5 and doing a partial revert of 8c25664, keeping only the test cases, is the best option, provided all the tests pass after these changes.
#1674 is not entirely fixed. I got a flipped svg using
imshow()
withorigin='lower'
. The snippet at the bottom reproduces the issue with the current master branch. This problem was introduced between v1.1.1 and v1.2.0rc3.I dug the issue a bit deeper, and found that 1c9f9b5 introduced the issue. The commit seems a performance tweak for nearest neighbor scaling in a certain condition. Reverting 1c9f9b5 and 8c25664 fixes the issue.
I suggest to revert both commits, but to keep the test cases introduced in 8c25664. @mdboom, is this ok for you to revert 1c9f9b5 for now?
The text was updated successfully, but these errors were encountered: