Fix set dashes for line collections #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estyles to LineCollection Conflicts: lib/matplotlib/contour.py
Conflicts: lib/matplotlib/tests/test_lines.py
|
@mdboom Is this unit test alright? |
|
Sure -- I wonder if we also couldn't do a image test (or extend one of the existing contour tests) to make sure the dashes are in fact in the result. Thanks for doing this -- I think we're still waiting to see if @efiring has any better way to fix the underlying bug(s)... I think this fix is probably fine for now (and is certainly minimal). |
|
Done. |
|
Looks good. |
|
Alright, I think the best course of action is to merge this so it makes the release and if @efiring comes up with a cleaner approach, there's nothing to stop us pursuing it after the 1.2.1 release. Any objections? |
|
Seems right to me. |
dmcdougall
added a commit
that referenced
this pull request
Jan 31, 2013
Fix set dashes for line collections
This was referenced Jan 31, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1704 targetting v1.2.x and with a unit test. It fixes #1701.