Fix clip_path_to_rect, add convenience method on Path object for it #1778
Conversation
…clip_to_rect and adds a new clip_to_bbox method to Path that returns a Path object. Adds a test that tests clipping compound paths and multiple subsegments.
| lengths = [len(x) for x in args] | ||
| total_length = sum(lengths) | ||
|
|
||
| vertices = np.vstack([x.vertices for x in args]) | ||
| vertices.reshape((total_length, 2)) | ||
|
|
||
| codes = cls.LINETO * np.ones(total_length) | ||
| codes = np.ones(total_length, dtype=cls.code_type) |
There was a problem hiding this comment.
Would this be better as np.repeat(cls.LINETO, total_length)? (Though I'm not sure you can specify the dtype that way)
There was a problem hiding this comment.
Otherwise, it may as well be np.empty?
There was a problem hiding this comment.
Indeed. I think np.empty is the best here.
|
Looks good to me. Just a couple of comments, but I'd be happy enough to merge this early next week. Good stuff @mdboom! |
Fix clip_path_to_rect, add convenience method on Path object for it
Aternative to #1777. Properly closes the paths returned by clip_to_rect and adds a new clip_to_bbox method to Path that returns a Path object. Adds a test that tests clipping compound paths and multiple subsegments.