Fix for #1792 #1794
Merged
Fix for #1792 #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set an upper limit for the range of versions installable by pip
| @@ -939,7 +939,7 @@ def get_install_requires(self): | |||
| if sys.version_info[0] >= 3: | |||
| return ['pyparsing>=2.0.0'] | |||
| else: | |||
| return ['pyparsing>=1.5.6'] | |||
| return ['pyparsing>=1.5.6,<=1.5.7'] | |||
There was a problem hiding this comment.
For future proofing should this not be 2.0.0?
There was a problem hiding this comment.
Ah, you mean strictly less than 2.0.0?
|
@pelson - I fixed the version requirement to make it future proof, on the assumption that the 1.x branch of pyparsing will always remain Python 2 compatible. |
|
@pelson - it looks like Travis passed, so feel free to merge if you are happy with it. |
|
Yeah -- I had thought |
|
Also see the tangentially related #1788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of pyparsing 2.0.0, Python 2 is no longer supported, so we need to set an upper limit for the range of versions installable by pip.