New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_backend_pgf: TypeError #1843
test_backend_pgf: TypeError #1843
Conversation
The tol parameter was missing in the call to compare_images().
This is a fix for Issue #1842. The problem was that I deleted the In the spirit of the original patch, I have set tol to 10 (the default in |
This works for me on my local machine |
I'm getting two failed tests with this: |
I fiddled with the tolerance parameter and found that for my system a tolerance of 14 was enough to remove both failures, in case that helps to put my previous comment into context... |
Thanks for testing again, Andrew. We've* noticed that the text rendering can be a bit off on different systems, which is why there is tolerance at all. So I think we agreed to generally set the tolerances at 10 by default, and bump them up to whatever is necessary whenever someone has a "correct" render that fails the test (as opposed to something genuinely wrong). Good thing you attached the image; it looks like you have hit just this case, so I am bumping up the tolerance to 14. Can you test it again and make sure it passes? *I say "we" not implying that I'm a maintainer of this library. I just contributed a rewrite of the comparison code, and these were my findings at the time. |
This successfully removes the test failures for me. |
$ python tests.py matplotlib.tests.test_backend_pgf
...
----------------------------------------------------------------------
Ran 3 tests in 5.570s
OK |
test_backend_pgf: TypeError
The tol parameter was missing in the call to
compare_images()
.