Fixed polygon3d rendering bug issue #178 #1928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| seg3d = [juggle_axes(x, y, z, zdir) for (x, y, z) in seg] | ||
| return seg3d | ||
| return seg3d, codes |
There was a problem hiding this comment.
This changes the API of this function. The correct way to go about this is to deprecate this one and have a new function set up to replace it. Or, have a kwarg defaulting to False to indicate whether to return the codes as well.
There was a problem hiding this comment.
@WeatherGod: I have changed all code that calls this and the other function you have highlighted. I see these as internal (i.e. private) functions, even though they are do not have leading underscores.
There was a problem hiding this comment.
They are not private. These are public methods to objects that people do manipulate in the wild. You will have to go through the proper process for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a candidate fix for the mplot3d polygon rendering bug of issue #178; it will also allow PR #1299 to proceed.
The changes are all in the mplot3d code, except for one new function in
collections.pywhich is only called from mplot3d code. With this fix the test script added by @WeatherGod to #178 works OK, and all the existing mplot3d examples work as before.The code changes are not elegant, but are consistent with existing mplot3d code.
I haven't PEP8'd the changes as the original mplot3d files haven't been PEP8'd yet.