Build: allow local static png dependency #1970
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To start with, I am very new to building with windows SDK - so this issue is probably related with a bad practise: please tell.
Since commit 386b4e5 I have been unable to build using a local static png dependency (the one generously provided online by: http://www.lfd.uci.edu/~gohlke/pythonlibs/#matplotlib). Previously it would build even with png version = None ; now a
CheckFailed
error is raised.As a workaround I ended adding the same try / catch pattern in check method of
Png
class as in theLibAgg
class ofsetupext.py
. I am really unsure this the good thing to do ; however in this case I would be happy to learn.