Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg rasterize (rebased) #2044

Merged
merged 9 commits into from May 24, 2013
Merged

Svg rasterize (rebased) #2044

merged 9 commits into from May 24, 2013

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented May 21, 2013

This is a rebased version of #1185. It also updates some test images and adds get_image_magnification to the RendererBase class at @pelson's suggestion.

@mdboom
Copy link
Member Author

mdboom commented May 24, 2013

The matplotlib.tests.test_image.test_rasterize_dpi.test is failing on Travis, but I can't reproduce locally. Is anyone else able to reproduce, and maybe could post the result image here?

@mdboom
Copy link
Member Author

mdboom commented May 24, 2013

Nevermind -- got it reproduced. I'm on it.

@mdboom mdboom closed this May 24, 2013
@mdboom mdboom reopened this May 24, 2013
@mdboom
Copy link
Member Author

mdboom commented May 24, 2013

Hmm.. github seems to be borked here. The tip of this branch is f288b4e (which I just verified by doing a clean clone), but it's displaying 90143c0, both here and at https://github.com/mdboom/matplotlib/commits/svg-rasterize. Looks like a bug report to github might be in order.

@mdboom mdboom closed this May 24, 2013
@mdboom mdboom reopened this May 24, 2013
@mdboom
Copy link
Member Author

mdboom commented May 24, 2013

Weird. It's update now. Never seen it take that long before.

mdboom added a commit that referenced this pull request May 24, 2013
@mdboom mdboom merged commit f262892 into matplotlib:master May 24, 2013
@@ -264,6 +264,31 @@ def test_image_composite_alpha():
ax.set_ylim([5, 0])


@image_comparison(baseline_images=['rasterize_10dpi'], extensions=['pdf','svg'], tol=1.5e-3, remove_text=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test is failing on Python 3.3.

@mdboom mdboom deleted the svg-rasterize branch August 7, 2014 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants