You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some setuptools "stub" files for C extensions that only get exist when the C dependencies are present on the system. Unfortunately, these stub files are not PEP8 compliant, and making them PEP8 compliant would probably require patching setuptools.
The PEP8 conformance test will fail if these files are present, so I excluded them. However, since they don't exist on Travis, we now get this over there:
======================================================================
ERROR: matplotlib.tests.test_coding_standards.test_pep8_conformance
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/virtualenv/python2.7/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/home/travis/virtualenv/python2.7/local/lib/python2.7/site-packages/matplotlib-1.3.x-py2.7-linux-x86_64.egg/matplotlib/tests/test_coding_standards.py", line 231, in test_pep8_conformance
'{}'.format('\n '.join(unexpectedly_good)))
ValueError: Some exclude patterns were unnecessary as the files they pointed to either passed the PEP8 tests or do not point to a file:
*/matplotlib/backends/_backend_gdk.py
*/matplotlib/backends/_gtkagg.py
----------------------------------------------------------------------
I think I'd prefer it if it was just silent if an excluded file is missing.
There are some setuptools "stub" files for C extensions that only get exist when the C dependencies are present on the system. Unfortunately, these stub files are not PEP8 compliant, and making them PEP8 compliant would probably require patching setuptools.
Here's an example:
The PEP8 conformance test will fail if these files are present, so I excluded them. However, since they don't exist on Travis, we now get this over there:
I think I'd prefer it if it was just silent if an excluded file is missing.
@pelson: What do you think?
The text was updated successfully, but these errors were encountered: