Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color of candlestick lines #2207

Merged
merged 1 commit into from Jan 13, 2014
Merged

color of candlestick lines #2207

merged 1 commit into from Jan 13, 2014

Conversation

profholzer
Copy link
Contributor

the line of a candlestick should have the same color as the body (rectangle)

the line of a candlestick should have the same color as the body (rectangle)
@profholzer
Copy link
Contributor Author

Usually the upper and lower shadow have the same color as the body. The other option is to draw the body first to avoid the ugly black line through it.
But: If the background is black, the shadows will vanish.

@profholzer profholzer closed this Jul 7, 2013
@tacaswell
Copy link
Member

If you are going to do work on the finance.py could you do it against https://github.com/tacaswell/matplotlib/tree/ochl_to_ohlc (see PR #1920 ) to make the eventual merge easier?

If you actually use finance do you want to take over herding #1920 through merging?

@mdboom
Copy link
Member

mdboom commented Jul 16, 2013

@profholzer: Just so we don't lose track of this... Did you close because this is the wrong approach, or because you, following @tacaswell's suggestion, made this against his branch? If the latter, we should reference which PR that work moved to.

@profholzer
Copy link
Contributor Author

Hi,
this was my first attempt to give something back to the matplotlib developers and I simply don't know, what I should do exactly, because I am not familiar to the methods of reporting bugs or enhancements.
Sorry for my inactivity due to the wrong approach. I saw that other users made the same recommendation earlier.

Regards
Alexander

Am 16.07.2013 um 18:43 schrieb Michael Droettboom notifications@github.com:

@profholzer: Just so we don't lose track of this... Did you close because this is the wrong approach, or because you, following @tacaswell's suggestion, made this against his branch? If the latter, we should reference which PR that work moved to.


Reply to this email directly or view it on GitHub.

@mdboom
Copy link
Member

mdboom commented Jul 16, 2013

Ok -- why don't we do this, then. I'll reopen the bug, and once #1902 is merged, we can reassess where we are wrt this issue.

@mdboom mdboom reopened this Jul 16, 2013
@tacaswell
Copy link
Member

@mdboom There is a typo in your comment, it is #1920 not 1902

tacaswell added a commit that referenced this pull request Jan 13, 2014
@tacaswell tacaswell merged commit 2b9fced into matplotlib:master Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants