Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of mlab.pca - updated docstring, added saving the eigenvalues. #2239

Merged
merged 1 commit into from Jan 9, 2014
Merged

Update of mlab.pca - updated docstring, added saving the eigenvalues. #2239

merged 1 commit into from Jan 9, 2014

Conversation

blackw1ng
Copy link
Contributor

The old version of pca class did not save the Eigenvalues - just the "fractions" that are just percentage values.

Also added info which row of Wt one can find the Eigenvectors.

The old version of pca class did not save the Eigenvalues - just the "fractions" that are just percentage values.

Also added info which row of Wt one can find the Eigenvectors.
@mdboom
Copy link
Member

mdboom commented Jul 22, 2013

Does anyone else using the PCA class feel qualified to comment? The original code was by @jdh2358.

@NelleV
Copy link
Member

NelleV commented Jul 22, 2013

I've never used matplotlib's PCA, but I'm more than familiar with using it, and implementing (and reimplementing it, again and again). I can have a look at this PR tomorrow.

@tacaswell
Copy link
Member

@NelleV Did you ever get a chance to look at this PR?

@pelson
Copy link
Member

pelson commented Jan 9, 2014

Thanks @blackw1ng - this looks good to me.

pelson added a commit that referenced this pull request Jan 9, 2014
Update of mlab.pca - updated docstring, added saving the eigenvalues.
@pelson pelson merged commit 3cefb7a into matplotlib:master Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants