Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2339: render math text when using path effects #2340

Merged
merged 1 commit into from Aug 26, 2013

Conversation

lpsinger
Copy link
Contributor

Fixes #2339, and adds unit tests.

@@ -586,7 +586,8 @@ def draw(self, renderer):
self._fontproperties, angle)
else:
path_effect.draw_text(renderer, gc, x, y, clean_line,
self._fontproperties, angle)
self._fontproperties, angle,
ismath=ismath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. That's a simple change isn't it? 👍

@mdboom
Copy link
Member

mdboom commented Aug 26, 2013

@lpsinger: Thanks for looking into and fixing this. We're trying to cut down on the number of tests (as each one adds a lot of overhead). Would it be possible instead to add some math text to one of the existing path effect tests (and update the baseline images accordingly?)

Also, to notate for myself, this should be merged to the 1.3.x branch.

@lpsinger
Copy link
Contributor Author

Would it be possible instead to add some math text to one of the existing path effect tests (and update the baseline images accordingly?)

Done. Would you like me to squash these two commits together?

@mdboom
Copy link
Member

mdboom commented Aug 26, 2013

Yes, please squash the commits if you don't mind to reduce repo size.

@lpsinger
Copy link
Contributor Author

Yes, please squash the commits if you don't mind to reduce repo size.

Done.

mdboom added a commit that referenced this pull request Aug 26, 2013
Fix #2339: render math text when using path effects
@mdboom mdboom merged commit 6982560 into matplotlib:master Aug 26, 2013
mdboom added a commit that referenced this pull request Aug 26, 2013
Fix #2339: render math text when using path effects
@lpsinger lpsinger deleted the patheffects_math_text branch August 26, 2013 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math text with path effects is rendered as plain text
2 participants