New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: alpha parameter was ignored when fill color is #000000 #2415
Conversation
Would you mind including a regression test? (The current failures seem unrelated to this and are on master as well. You can ignore them until I fix master). |
@@ -35,6 +35,14 @@ def test_visibility(): | |||
parser.Parse(buf) # this will raise ExpatError if the svg is invalid | |||
|
|||
|
|||
@image_comparison(baseline_images=['fill_black_with_alpha'], | |||
extensions=['svg']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good test. Would you mind adding "remove_text=True" here to remove the text (just to make the test image file size smaller?)
Thanks. We're getting this test failure on Travis, Python 2.x only. (The other test failure is unrelated and can be ignored). I think the issue is the use of alpha='0.1' as a string.
|
Tests on Travis-CI seems to have been stopped due to some error from
|
Restart pushed. |
Thanks! |
@kshramt - I'm happy to merge this, but I think we should squash your commits into one. Something like:
Details at http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html Cheers! |
Bug: alpha parameter was ignored when fill color is #000000
ax.scatter(xs, ys, alpha=0.1, c='k')
did not produce transparent dots.