New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdfpages pagecount convenience getter method #2440
Conversation
Seems simple enough and has a test to boot! Waiting for Travis results, but this gets a +1 from me |
I am not very familiar with the test setup here, but I assumed the |
Yes, that is all that was needed. Merging! |
Pdfpages pagecount convenience getter method
Gah! How do I undo what I just did? This PR was set against the maintenance branch and not master. |
No way to undo it. |
bugfixes go into maintenance branch (v1.3.x), new features go into master. This was a (tiny) new feature, not a bugfix. |
Ok, sorry. My bad then, didn't know. |
Again, gladly this is an innocuous enhancement, rather than a deep algorithmic change, and if this doesn't get reverted, I wouldn't mind. Obviously the git paradigm of always moving forward with commits means that to revert a commit is literally to apply an inverse changeset - the original commit will always be there unless we break the golden rule of removing commits (which we really don't want to do - that would be a major headache). |
Yeah -- I'm fine with this staying on the branch, though strictly not a bugfix. |
Yes, no way to get rid of the commit itself but the change could be undone. In any case, seems its settled and its not a big deal anyway. |
Add convenience method
get_pagecount()
to PdfPages that returns the current number of pages in the multipage file. Also adds a simple test for it.