pep8 for backend_pdf.py

[megies]

Pep8 cleanup for pdf backend.

[mdboom]

@megies: Would you mind rebasing?

[megies]

Uhm, I never did that before (in this scenario, just for not-yet-pushed/local stuff) and usually just merge. You want to avoid a merge commit in here, I guess? I would have to force push and rewrite my fork's history then after rebasing, right? Fine with that, just want to make sure..

[mdboom]

That's correct. IMHO, a rebase is one of the few cases where a force push is ok.

[megies]

Ok, I usually don't rewrite published history, but it won't really hurt here of course..

[tacaswell]

Re-triggered travis. The last time this was run the pep8 checks were turned off on master. It is now failing because backend_pdf.py passes, but is on the exclude list.

Can you remove it from the exclude list in tests/test_coding_standards.py?

[megies]

@tacaswell.. thanks for looking at the build. Done.

[tacaswell]

It seems to have picked up conflicts and won't merge cleanly anymore, can you re-base again? 90% sure the conflict is another file being removed.

[megies]

Sure, no problem. Actually the conflict comes from one of my pull requests (cleaning up the pep8 code checker structure to be reusable).. ;)

[tacaswell]

I think we are trying to move away from \ line continuation to (...) continuation. iirc that is one of those things that they claim will be deprecated eventually (just like % formatting).

[megies]

Hmm, yes. Actually I also use ( ) normally, nowadays. I'll change it.

[WeatherGod]

OT: Just to quickly note, I think it was decided that '' can never be
deprecated until a solution is found for line continuations for "with"
clauses (you can't use parens for multiple "with" targets). And they can
try to pull '%' formatting from my cold, dead hands!

[efiring]

On 2013/10/31 5:20 AM, Thomas A Caswell wrote:

In lib/matplotlib/backends/backend_pdf.py:

     fontdictObject = self.reserveObject('font dictionary')
     self.writeObject(fontdictObject, fontdict)
     return fontdictObject

 def embedTeXFont(self, texname, fontinfo):

•    matplotlib.verbose.report(
  

•        'Embedding TeX font ' + texname + ' - fontinfo=' + repr(fontinfo.**dict**),
  

•        'debug')
  

•    msg = 'Embedding TeX font ' + texname + ' - fontinfo=' + \
  

•          repr(fontinfo.**dict**)
  

I think we are trying to move away from || line continuation to |(...)|
continuation. iirc that is one of those things that they claim will be
deprecated eventually (just like |%| formatting).

Use of the backslash has been contrary to mpl coding policy for a long
time, and is not related to any potential long-term shift to a new
continuation string--and as far as I know, there is no such new string.
One can use parentheses to avoid the trailing backslash. In a case like
the above, one can also make a list of the space-separated text chunks
to be concatenated and then use ' '.join(chunks).

[tacaswell]

Left a bunch of picky comments, most of which I think you can ignore if you don't like them.

[megies]

Both of the deletes you mentioned were unused variables if I remember correctly. But I can verify again..

[megies]

Like mentioned those two deletes above were unused variables. Personally I would leave them out, but if anybody wants them left in there I'll add them again.

[tacaswell]

👍 LGTM to me.