Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting navigation and toolbar #2557

Closed
wants to merge 2 commits into from

Conversation

fariza
Copy link
Member

@fariza fariza commented Oct 28, 2013

This is in response to the request to split #2465 into several smaller PRs.

Goals

Main Goal

Separate the navigation state from the GUI (or physical) toolbar. Without touching any base class (as much as possible), to avoid forced refactor of other backends.

Secondary Goal

Add reconfiguration capabilities to the toolbar

Implementation

The following base classes were added

  • NavigationBase: a derivate of NavigationToolbar2. This is the class that holds the state of the navigation.
  • ToolbarBase: This is the physical or GUI toolbar. with the following new public methods
    • remove_tool
    • add_tool
    • move_tool

Includes Gtk3 implementation

  • NavigationGTK3
  • ToolbarGTK3
  • Simple example of use examples/user_interfaces/reconfigurable_toolbar_gtk3.py

Future

If the functionality is worth the effort, and all the backends are ported to use this classes, it will be possible to merge NavigationBase and NavigationToolbar2.

Note

This is very similar to the idea of #1849 different implementation without touching the bases classes.

@fariza fariza closed this Jan 29, 2014
@fariza fariza deleted the reconfigurable-toolbar branch February 11, 2015 18:10
@QuLogic QuLogic modified the milestones: unassigned, proposed next point release (2.1) Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants