Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend_webagg.py #2648

Merged
merged 2 commits into from Dec 5, 2013
Merged

Update backend_webagg.py #2648

merged 2 commits into from Dec 5, 2013

Conversation

JamesMakela
Copy link
Contributor

Change WebAgg backend to handle stale figure UI controls in the browser

I found that when you create a figure, render it in a browser, and then close the figure, it leaves a UI in the browser with no associated figure on the server. This UI is still handling mouse cursor events and sending them, which was causing some annoying exceptions due to the backend trying to perform operations with an invalid fig_manager.

Change WebAgg backend to handle stale figure UI controls in the browser
@mdboom
Copy link
Member

mdboom commented Dec 4, 2013

Looks good in general. I'll leave this up for a while in case others have comments..., but it makes sense to me.

We are generating 'ReferenceError: figure is not defined' when we try to download a figure into a particular image type.
@pelson
Copy link
Member

pelson commented Dec 5, 2013

@mdboom - I'm 👍 on this too (untested) so lets go ahead and merge.

tacaswell added a commit that referenced this pull request Dec 5, 2013
@tacaswell tacaswell merged commit 6cf05d0 into matplotlib:master Dec 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants