Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IPython's copy of ipython_console_highlighting Sphinx ext, if available #2656

Merged

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Dec 6, 2013

No description provided.

@pelson
Copy link
Member

pelson commented Dec 9, 2013

Why not remove our version and just use IPython's? It is IPython specific functionality and should live there IMHO...

@mdboom
Copy link
Member Author

mdboom commented Dec 9, 2013

That's the plan, and why I suggested it be added to IPython in the first place. There's two issues: 1) I'm not sure we want to grow a dependency on IPython, particularly recent versions. 2) Since the plugin began in matplotlib, many users are still using it from there, so it needs to be deprecated gracefully.

pelson added a commit that referenced this pull request Dec 10, 2013
…-if-available

Use IPython's copy of ipython_console_highlighting Sphinx ext, if available
@pelson pelson merged commit e4fc86f into matplotlib:v1.3.x Dec 10, 2013
@mdboom mdboom deleted the use-ipython-console-highlighting-if-available branch August 7, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants