Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate toolbarqt4agg #2680

Merged
merged 3 commits into from Dec 16, 2013
Merged

Conversation

tacaswell
Copy link
Member

house keeping from removing extra *QTAgg classes.

Added NavigationToolbar2QTAgg back with a deprecation warning

Added entry to api_changes.rst
@@ -168,5 +170,15 @@ def print_figure(self, *args, **kwargs):
self.draw()


class NavigationToolbar2QTAgg(NavigationToolbar2QT):
def __init__(*args, **kwargs):
warnings.warn('This class has been depreciated in 1.4 ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be "deprecated".

@efiring
Copy link
Member

efiring commented Dec 14, 2013

Looks fine apart from the trivial typo noted above. Thank you for cleaning up the mess I left.

@tacaswell
Copy link
Member Author

Sorry about the typo. I trust spell check too much some times.

@tacaswell
Copy link
Member Author

@efiring Want push the green button?

efiring added a commit that referenced this pull request Dec 16, 2013
@efiring efiring merged commit e66039b into matplotlib:master Dec 16, 2013
@tacaswell tacaswell deleted the deprec_toolbarqt4Agg branch December 16, 2013 21:47
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jan 10, 2015
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jan 10, 2015
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jan 11, 2015
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants