Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on MacOS X 10.5.8 (PowerPC G5) with Python 3.3.3 #2690

Merged
merged 1 commit into from Jan 7, 2014

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jan 6, 2014

La Défense, le 20/12/2013

Hi

Using commit 8c16c61 .

I get a build failure on MacOS X 10.5.8 (PowerPC G5 - still have to use it) with Python 3.3.3 and powerpc-apple-darwin9-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5566):

src/_macosx.m: In function ‘GraphicsContext_draw_text’:
src/_macosx.m:2828: error: expected ‘)’ before ‘{’ token
src/_macosx.m:2892: error: expected expression before ‘}’ token
error: command 'gcc' failed with exit status 1

The same code compiles fine under MacOS X 10.9.1 (Intel) with Python 3.3.3 and clang.

Thanks

Hubert Holin

@mdboom
Copy link
Member

mdboom commented Dec 30, 2013

@mdehoon

@mdehoon
Copy link
Contributor

mdehoon commented Dec 30, 2013

Can you check in lines 33-35 whether COMPILING_FOR_10_5 is defined on your system?

#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1050
#define COMPILING_FOR_10_5
#endif

As the error occurs in line 2828, it seems that COMPILING_FOR_10_5 is not defined on your system, although you are using Mac OS X 10.5.

@HubertHolin
Copy link
Contributor Author

Paris (U.E.), le 30/12/2013

Bonsoir

    I am out of the office right now (where the older system is), but will check when I get back to work early next week.

Merci

        Hubert Holin

On 30 déc. 2013, at 16:01, mdehoon notifications@github.com wrote:

Can you check in lines 33-35 whether COMPILING_FOR_10_5 is defined on your system?

#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1050
#define COMPILING_FOR_10_5
#endif

As the error occurs in line 2828, it seems that COMPILING_FOR_10_5 is not defined on your system, although you are using Mac OS X 10.5.


Reply to this email directly or view it on GitHub.

@HubertHolin
Copy link
Contributor Author

La Défense, le 06/01/2014

Bonsoir

Actually, one closing parenthesis is missing at the end of line 2827. Add it and all compiles fine.

Merci, and my best wishes for this new year!

Hubert Holin

@mdboom
Copy link
Member

mdboom commented Jan 6, 2014

Thanks for tracking this down. I've attached a fix (as you suggested).

@mdehoon
Copy link
Contributor

mdehoon commented Jan 7, 2014

Good to hear it was a simple typo. The fix looks good to me.

mdboom added a commit that referenced this pull request Jan 7, 2014
Build failure on MacOS X 10.5.8 (PowerPC G5) with Python 3.3.3
@mdboom mdboom merged commit 419fd84 into matplotlib:master Jan 7, 2014
@mdboom mdboom deleted the mac-compile branch August 7, 2014 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants