Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare pep #2713

Merged
merged 3 commits into from Jan 13, 2014
Merged

Compare pep #2713

merged 3 commits into from Jan 13, 2014

Conversation

pelson
Copy link
Member

@pelson pelson commented Jan 10, 2014

The matplotlib.testing.compare module was a PEP8 nightmare (3 space indents etc.) which I've seen many a time and never got around to fixing... until now!

I've taken a thorough review of the code, and whilst it isn't particularly pretty, it does do a job, so I've not made any interface modifications, but I have taken the opportunity to add some docstrings and improve some of the error message formatting code (its all superficial and not functional).

Anyway, as a result of this, I now know how the RMS is calculated at least 馃槃.

@tacaswell
Copy link
Member

Given that the diffs is so gnarly, maybe we should hold of on merging this until after 1.4 is pulled out just to be safe.

re-started the tests so they pass.

@pelson
Copy link
Member Author

pelson commented Jan 13, 2014

Given that the diffs is so gnarly, maybe we should hold of on merging this until after 1.4 is pulled out just to be safe.

I'm not a huge fan of that approach. We haven't cut a release candidate, I've taken a lot of care with the changes and importantly the tests still pass. Additionally maintaining a release branch with a significantly different file on master is often a merge headache.

Essentially, if you're willing to review it, I'm happy to back it as a PR in v1.4. 馃槃

@mdboom
Copy link
Member

mdboom commented Jan 13, 2014

I agree -- Let's try to get this in 1.4 before the release candidate.

@tacaswell
Copy link
Member

I see your point about having to see this diff all the time being worse.

I just went through the changes carefully and agree that it looks good. 馃憤 to merge from me.

mdboom added a commit that referenced this pull request Jan 13, 2014
@mdboom mdboom merged commit 113c352 into matplotlib:master Jan 13, 2014
@pelson
Copy link
Member Author

pelson commented Jan 14, 2014

Thanks guys. It wasn't a pleasant PR to review, but hopefully the days of PEP8 fixes are numbered 馃槃

@pelson pelson deleted the compare_pep branch February 12, 2014 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants