Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc on rebase a pull request #2733

Closed
fariza opened this issue Jan 15, 2014 · 5 comments
Closed

doc on rebase a pull request #2733

fariza opened this issue Jan 15, 2014 · 5 comments
Assignees
Milestone

Comments

@fariza
Copy link
Member

fariza commented Jan 15, 2014

In the http://matplotlib.org/devel/gitwash/development_workflow.html should be a section for rebase a pull request, it is pretty common to be asked to do it.

@pelson
Copy link
Member

pelson commented Jan 17, 2014

Great idea. I'd love to see this in the v1.4 release, but it might miss it. Are you interested in submitting a PR @fariza ?

@fariza
Copy link
Member Author

fariza commented Jan 17, 2014

My Git knowledge is very limited.

@ghost ghost assigned tacaswell Jan 17, 2014
@tacaswell
Copy link
Member

I'll try to write something up today.

@cimarronm
Copy link
Contributor

Looks good @tacaswell 👍 This is definitely useful for new guys learning git and github. I would have benefited from it.

@pelson
Copy link
Member

pelson commented Jan 21, 2014

Closing in favour of the PR.

@pelson pelson closed this as completed Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants