Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes artificial limit in artist picker traversal. There are quite a #2756

Merged
merged 2 commits into from Jan 27, 2014

Conversation

cimarronm
Copy link
Contributor

few object (fig, VPacker, etc.) which do not contain an axes property
and would not be traversed for picking logic without this change.

few object (fig, VPacker, etc.) which do not contain an axes property
and would not be traversed for picking logic without this change.
@cimarronm
Copy link
Contributor Author

This combined with PR #2755 completely resolve issue #1962.

@tacaswell
Copy link
Member

What does this fix that #2755 does not?

@tacaswell
Copy link
Member

nm, I see the other comment now.

@tacaswell
Copy link
Member

I am worried about unintended consequences of this. I assume this was added for some reason.

It looks like the test was first added in 571c8bc (2009) and then extended in 3509b3b (2010).

that children are picked if the current object does not have an axes
property.
@cimarronm
Copy link
Contributor Author

@tacaswell I agree. I thought about it a bit more and think there is a better solution. I added a check so that it will pick the children in the current object if it does not have an axes property.

This still fixes the previous issues and keeps in tact the logic that is does not traverse children of an object whose axes property does not match that in which the mouse event occurred (if indeed that logic is doing something more than just optimization or weeding out of calls).

This seems like a sound approach but let me know if you guys see anything wrong.

@mdboom
Copy link
Member

mdboom commented Jan 23, 2014

@cimarronm: I was just going to suggest exactly that, but you beat me to it. This seems to address your issues while also not breaking the current check.

mdboom added a commit that referenced this pull request Jan 27, 2014
Removes artificial limit in artist picker traversal. There are quite a
@mdboom mdboom merged commit 6ab156f into matplotlib:master Jan 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants