Python 3 METH_VARARGS with METH_KEYWORDS #2807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
METH_VARARGS
to the method definition flags in _macosx.m as Python 3 requiresMETH_VARARGS
to be set whenMETH_KEYWORDS
is set. This is already the case whereMETH_KEYWORDS
is used elsewhere, namely _ttconv.cpp and cntr.c.Without this and executing within Python3 one will get the error
SystemError: Bad call flags in PyCFunction_Call. METH_OLDARGS is no longer supported!