New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG : Qt repaint workaround on windows #2844
Conversation
Added platform specific replacement of `update` with `repaint` in `FigureCanvasQtAgg.draw` for windows.
This works and should be merged. What happens under windows is that the update events are posted, but the painting happens quite unregular, sometimes only every 20th update. Don't know the reason why. One remark: I think also non-windows should use repaint. |
This should be merged before the next release. |
@Tillsten That is the plan. It is waiting on some one else but me to push the big green button. |
@tacaswell Any comment to the point i made? |
As discussed in #2559 , I do not want to go against the suggestions of the QT docs with out a very good reason, in this case, the reason is that windows is a broken platform. The change makes no difference on linux (and I suspect mac as no mac-users have complained about this and there are a few devs who I know use both mac and the QT backend) so there is no reason to expose the other systems to the possible consequences of miss-using the gui toolkit. We should in general not be fighting the event-loop. The behaviour I expect from |
BUG : Qt repaint workaround on windows
Sorry to bring up this PR again, but i think this should go at least to changes.txt. |
@Tillsten Yeah, you are right. |
DOC : added missing doc changes from #2844
@Tillsten I have completely come around on the need for this on windows, sorry for the push back. |
Added platform specific replacement of
update
withrepaint
inFigureCanvasQtAgg.draw
for windows.