Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging 1.3.x broke build on master #2878

Closed
tacaswell opened this issue Mar 8, 2014 · 2 comments · Fixed by #2884
Closed

merging 1.3.x broke build on master #2878

tacaswell opened this issue Mar 8, 2014 · 2 comments · Fixed by #2884
Milestone

Comments

@tacaswell
Copy link
Member

The issues is with matplotlib.tests.test_streamplot.test_streamplot_limits and matplotlib.tests.test_collections.test_barb_limits which passed on 1.3.x before the merge.

@pelson Can you take a look at this?

Related to #2444

@tacaswell tacaswell added this to the v1.4.0 milestone Mar 8, 2014
@tacaswell tacaswell added cantfix and removed cantfix labels Mar 8, 2014
@pelson
Copy link
Member

pelson commented Mar 10, 2014

@pelson Can you take a look at this?

Sure.

Looks like the numbers are pretty close:

Arrays are not almost equal to 2 decimals

(mismatch 25.0%)
 x: array([ 19.99259073,  29.99042969,  15.01481855,   6.01914062])
 y: array([20, 30, 15,  6])

Dropping this from 2 decimals to 1 would be sufficient - the fact is that streamplot will not result in exact limits as it is the extents of the resulting paths which are used, not the input data itself.

The same issue applies to the barb test.

@tacaswell
Copy link
Member Author

Merged the PR, but I am still a bit concerned that it passed on 1.3.x before the merge, but not on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants