Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 links on the screenshot page #2908

Closed
sylvestre opened this issue Mar 19, 2014 · 9 comments
Closed

404 links on the screenshot page #2908

sylvestre opened this issue Mar 19, 2014 · 9 comments
Assignees
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone

Comments

@sylvestre
Copy link

here: http://matplotlib.org/users/screenshots.html
All files listed in this sentence leads to a 404 page:
It’s also simple to create stacked bars (bar_stacked.py), candlestick bars (finance_demo.py), and horizontal bar charts (barh_demo.py).

@tacaswell tacaswell added this to the v1.4.0 milestone Mar 19, 2014
@tacaswell tacaswell added the doc label Mar 19, 2014
@NelleV
Copy link
Member

NelleV commented Mar 19, 2014

This is probably due to the reorganization of the gallery.
Thanks for reporting.

@tacaswell
Copy link
Member

I just screwed up and pushed a fix for this directly to master def29e1 (forgot to change branches, accidentally committed to master and my local master was set up to track matplotlib/master and the push worked). I have changed what my local master thinks is upstream so it should not happen again. I'm just going to leave it as it is completely doc changes.

There are still a bunch of broken links in the png/highres/pdf links for a sub-set (~80) of the plot-directive calls. The images are put in _images/ but the urls don't point at them. For example the links in http://matplotlib.org/users/whats_new.html#mplot3d-graphs-can-be-embedded-in-arbitrary-axes are broken in a rebuild of the docs.

@tacaswell
Copy link
Member

@mdboom Can you take a look at the issues with the plot directive?

@dmcdougall
Copy link
Member

@mdboom
Copy link
Member

mdboom commented Jul 11, 2014

@dmcdougall: are some of these due to the plot directive screwing up, or are they all just "one off" errors?

@dmcdougall
Copy link
Member

@mdboom Yes. I'm looking into it now.

@dmcdougall
Copy link
Member

Ok, so I think the hyperlinks are actually correct. Here's a couple of examples of the variables used by the plot_directive function:

source_rel_name mpl_examples/pylab_examples/triplot_demo.py
source_rel_dir mpl_examples/pylab_examples
build_dir /Users/damon/git/github/matplotlib/doc/build/plot_directive/mpl_examples/pylab_examples
dest_dir /Users/damon/git/github/matplotlib/doc/build/html/mpl_examples/pylab_examples
dest_dir_link ../mpl_examples/pylab_examples
source_rel_name pyplots/whats_new_1_subplot3d.py
source_rel_dir pyplots
build_dir /Users/damon/git/github/matplotlib/doc/build/plot_directive/pyplots
dest_dir /Users/damon/git/github/matplotlib/doc/build/html/pyplots
dest_dir_link ../pyplots

I have a feeling the problem is that the figures are just not being generated into the correct directory.

@dmcdougall
Copy link
Member

This is removing the generated figures from the dest_dir.

Edit: That took forever to find.

@dmcdougall
Copy link
Member

Fixed in #3253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

No branches or pull requests

6 participants