Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webagg generated JS quotes #2975

Closed
mighq opened this issue Apr 12, 2014 · 5 comments
Closed

webagg generated JS quotes #2975

mighq opened this issue Apr 12, 2014 · 5 comments
Labels
status: needs clarification Issues that need more information to resolve.

Comments

@mighq
Copy link

mighq commented Apr 12, 2014

there is html entity instead of single quote in generated JS code:

fig = new figure('1', websocket_url_prefix);

v: Py 2.7.6, MPL 1.3.1, x86_64

@tacaswell
Copy link
Member

Can you give a bit more context of how you generate this and why it is a problem?

Can you reproduce this on master (there was recently some changes to how escaping is done)?

@tacaswell
Copy link
Member

Closing due to lack of communication. Please re-open with more details.

@btel
Copy link

btel commented Jul 14, 2014

I get the same problem. I try to show a figure with webagg backend on macosx (MPL 1.3.1 installed via pip). When I open the page in a browser and click on Figure 1 nothing shows up. In the javascript console there is a syntax error. The JS source contains the html entities given by @mighq.

@tacaswell
Copy link
Member

@mdboom @pelson Can you take a look at this to see if it is fixed on master?

@btel
Copy link

btel commented Jul 14, 2014

Indeed it works fine on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs clarification Issues that need more information to resolve.
Projects
None yet
Development

No branches or pull requests

3 participants