let KeyErrors pass silently on callback removal #2985
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a spurious KeyError when I remove an event connection during another event. This patch fixes that by letting it pass silently. I don't have a failing test written as the contribution guidelines request; I'm hoping this commit can be accepted despite that as it is pretty innocent & writing such a test seems to be breaking very new ground -- there is only one test containing "mpl_connect" and simulating events with-out picking a backend is unknown to me.