BUG: Showing a BboxImage can cause a segmentation fault #3009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to issue #2963. It turns out that BboxImage's
make_image
method could potentially calculate a negative width or height if it was constructed from an "inverted" Bbox, which is then passed toImage::resize
.From there, the width and height are interpreted as unsigned by agg, which leads to a segfault.
Small example:
This revealed another problem, in
BboxImage.show
, since (once fixed), inverting the order of the two corners passed into the Bbox constructor changes where the image is rendered.